Review Request: Adapt okteta plugin (filemanager modification)

Benjamin Port port.benjamin at gmail.com
Fri Jan 14 17:34:56 UTC 2011



> On Jan. 13, 2011, 10:35 p.m., Milian Wolff wrote:
> > utils/okteta/oktetaplugin.cpp, line 111
> > <http://git.reviewboard.kde.org/r/100379/diff/1/?file=6805#file6805line111>
> >
> >     this looks wrong, you should iterate over all urls and find all files, not only the first one.

File manager don't allow to select more than one file/directory


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100379/#review877
-----------------------------------------------------------


On Jan. 13, 2011, 9:14 p.m., Benjamin Port wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100379/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2011, 9:14 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Adapt okteta plugin (See filemanager modification: http://git.reviewboard.kde.org/r/100378/ )
> 
> 
> Diffs
> -----
> 
>   utils/okteta/oktetaplugin.cpp 5abecaf 
> 
> Diff: http://git.reviewboard.kde.org/r/100379/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110114/38480563/attachment.html>


More information about the KDevelop-devel mailing list