Review Request: Adapt okteta plugin (filemanager modification)

Milian Wolff mail at milianw.de
Thu Jan 13 22:35:29 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100379/#review877
-----------------------------------------------------------


see below, iterate over all selected urls and add all non-file urls. compare to the code below for the projectitem context


utils/okteta/oktetaplugin.cpp
<http://git.reviewboard.kde.org/r/100379/#comment699>

    this looks wrong, you should iterate over all urls and find all files, not only the first one.


- Milian


On Jan. 13, 2011, 9:14 p.m., Benjamin Port wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100379/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2011, 9:14 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Adapt okteta plugin (See filemanager modification: http://git.reviewboard.kde.org/r/100378/ )
> 
> 
> Diffs
> -----
> 
>   utils/okteta/oktetaplugin.cpp 5abecaf 
> 
> Diff: http://git.reviewboard.kde.org/r/100379/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110113/66ae9293/attachment.html>


More information about the KDevelop-devel mailing list