Review Request: Allow to modify context menu in filemanager for directories

[Andreas Pakulat]

> On Jan. 13, 2011, 10:15 p.m., Milian Wolff wrote:
> > looks good, please get it into 4.2 (assuming the action text is copied from the ProjectItemContext action in grepview, i.e. no new string is added)
> 
> Andreas Pakulat wrote:
>     Actually that doesn't work I think. Each plugin has its own catalog and afaik you cannot use strings from a different catalog without breaking the string-freeze.
> 
> Milian Wolff wrote:
>     morning Andreas, you should take another look at the code ;-P
>     
>     The "new" string is in grepview plugin, hence in the same catalog. It should be the same string than a few lines above in grepviewplugin.cpp for the ProjectItemContext.

I can't take 'another' look, I didn't look at the code at all, was just judging based on title and subject of the entry. So I stand corrected, it does work in this case :)


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100378/#review876
-----------------------------------------------------------


On Jan. 13, 2011, 9:11 p.m., Benjamin Port wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100378/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2011, 9:11 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Currently, a plugin can only modify filemanager context menu for a file. With this patch, plugin can modify context menu for files and directories.
> This patch modify open with plugin (in order to consider filemanager modification and only add action for directories).
> And the grep plugin to allow user to perform a search directly from a directory context menu in the file manager.
> 
> Another patch modify the okteta plugin (kdevelop)
> 
> 
> Diffs
> -----
> 
>   plugins/filemanager/filemanager.cpp c46d38f 
>   plugins/grepview/grepviewplugin.cpp 9d83d25 
>   plugins/openwith/openwithplugin.cpp 0b3672a 
> 
> Diff: http://git.reviewboard.kde.org/r/100378/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110114/898cc18e/attachment.html>