<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100378/">http://git.reviewboard.kde.org/r/100378/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 13th, 2011, 10:15 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good, please get it into 4.2 (assuming the action text is copied from the ProjectItemContext action in grepview, i.e. no new string is added)</pre>
</blockquote>
<p>On January 14th, 2011, 7:59 a.m., <b>Andreas Pakulat</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually that doesn't work I think. Each plugin has its own catalog and afaik you cannot use strings from a different catalog without breaking the string-freeze.</pre>
</blockquote>
<p>On January 14th, 2011, 9:56 a.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">morning Andreas, you should take another look at the code ;-P
The "new" string is in grepview plugin, hence in the same catalog. It should be the same string than a few lines above in grepviewplugin.cpp for the ProjectItemContext.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can't take 'another' look, I didn't look at the code at all, was just judging based on title and subject of the entry. So I stand corrected, it does work in this case :)</pre>
<br />
<p>- Andreas</p>
<br />
<p>On January 13th, 2011, 9:11 p.m., Benjamin Port wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Benjamin Port.</div>
<p style="color: grey;"><i>Updated Jan. 13, 2011, 9:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, a plugin can only modify filemanager context menu for a file. With this patch, plugin can modify context menu for files and directories.
This patch modify open with plugin (in order to consider filemanager modification and only add action for directories).
And the grep plugin to allow user to perform a search directly from a directory context menu in the file manager.
Another patch modify the okteta plugin (kdevelop)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/filemanager/filemanager.cpp <span style="color: grey">(c46d38f)</span></li>
<li>plugins/grepview/grepviewplugin.cpp <span style="color: grey">(9d83d25)</span></li>
<li>plugins/openwith/openwithplugin.cpp <span style="color: grey">(0b3672a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100378/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>