Review Request: Make "No matching function call" candidates clickable in build output
Aleix Pol Gonzalez
aleixpol at gmail.com
Thu Feb 24 23:31:43 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100738/#review1637
-----------------------------------------------------------
Looks interesting :)
projectbuilders/makebuilder/makeoutputmodel.h
<http://git.reviewboard.kde.org/r/100738/#comment1394>
Why did you change the order of the enumerees?
- Aleix
On Feb. 24, 2011, 11:01 p.m., Manuel Massing wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100738/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2011, 11:01 p.m.)
>
>
> Review request for KDevelop.
>
>
> Summary
> -------
>
> When gcc encounters a non-matching function call, it spits out a
> list of candidate methods. This patch makes the lines with candidate methods
> clickable, so one can jump to the declaration.
>
> The patch also introduces a differentiation between informative/warning
> messages, which is not really necessary for this patch, but might prove useful
> in the future. This part assumes that MakeOutputModel.h does not need to
> retain interface compatibility.
>
>
> Diffs
> -----
>
> projectbuilders/makebuilder/makeoutputdelegate.h 439d845
> projectbuilders/makebuilder/makeoutputdelegate.cpp b3d9002
> projectbuilders/makebuilder/makeoutputmodel.h 5ac4553
> projectbuilders/makebuilder/makeoutputmodel.cpp 09bb72e
>
> Diff: http://git.reviewboard.kde.org/r/100738/diff
>
>
> Testing
> -------
>
> Tested functionality by building C++ code (with gcc) which exhibits the "Non-matching function call" error
> (e.g. by intentionally omitting a required parameter to a function call).
>
>
> Thanks,
>
> Manuel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110224/77655c2c/attachment.html>
More information about the KDevelop-devel
mailing list