Review Request: Ouf of projet file directory in Find/Replace "sync" button's dropdown

[Olivier Jean de Gaalon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100682/#review1496
-----------------------------------------------------------


Ignore previous review, it actually breaks from the loop if hadUrl contains the current url, instead of just skipping it.
Still, you could do without the bool by just checking if hadUrl already contains the current url, and adding it if not.

- Olivier Jean de


On Feb. 19, 2011, 12:50 a.m., Lambert CLARA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100682/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2011, 12:50 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> In the "Find/Replace" dialog, if the current active file is not part of the project its directory is not present in the "sync" button's dropdown's list.
> This patch adds it.
> 
> 
> Diffs
> -----
> 
>   plugins/grepview/grepdialog.cpp e96419c 
> 
> Diff: http://git.reviewboard.kde.org/r/100682/diff
> 
> 
> Testing
> -------
> 
> Open two projects and an "orphan" file. With this file active, open the Find/Replace dialog and check the presence of its directory in the "sync" button dropdown.
> 
> 
> Thanks,
> 
> Lambert
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110219/7dca1caf/attachment.html>