Review Request: Ouf of projet file directory in Find/Replace "sync" button's dropdown

[Olivier Jean de Gaalon]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100682/#review1495
-----------------------------------------------------------


If you just add these two lines before the while loop:
  hadUrls.insert(url);
  addUrlToMenu(ret, url);

I think it would have the same effect of "Add url for current file in any case, plus all parents in project if applicable", without the need for the extra boolean.

- Olivier Jean de


On Feb. 19, 2011, 12:50 a.m., Lambert CLARA wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100682/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2011, 12:50 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> In the "Find/Replace" dialog, if the current active file is not part of the project its directory is not present in the "sync" button's dropdown's list.
> This patch adds it.
> 
> 
> Diffs
> -----
> 
>   plugins/grepview/grepdialog.cpp e96419c 
> 
> Diff: http://git.reviewboard.kde.org/r/100682/diff
> 
> 
> Testing
> -------
> 
> Open two projects and an "orphan" file. With this file active, open the Find/Replace dialog and check the presence of its directory in the "sync" button dropdown.
> 
> 
> Thanks,
> 
> Lambert
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110219/80ccbac6/attachment.html>