Review Request: Add options to StandardOutputView plugin

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100666/#review1474
-----------------------------------------------------------


some changes required, but good work already. thanks


outputview/ioutputview.h
<http://git.reviewboard.kde.org/r/100666/#comment1237>

    please add a NoOptions = 0x0



outputview/ioutputview.h
<http://git.reviewboard.kde.org/r/100666/#comment1239>

    the default was ShowItemsButton before, right? keep that. Or at least use NoOptions as suggested above



plugins/standardoutputview/CMakeLists.txt
<http://git.reviewboard.kde.org/r/100666/#comment1241>

    why is this removed?



plugins/standardoutputview/outputwidget.cpp
<http://git.reviewboard.kde.org/r/100666/#comment1242>

    make this "filter..." or "search..."



plugins/standardoutputview/outputwidget.cpp
<http://git.reviewboard.kde.org/r/100666/#comment1243>

    this should be something like "Enter a wild card string to filter the output view"



plugins/standardoutputview/outputwidget.cpp
<http://git.reviewboard.kde.org/r/100666/#comment1244>

    looks wrong, remove this



plugins/standardoutputview/outputwidget.cpp
<http://git.reviewboard.kde.org/r/100666/#comment1245>

    this is missing the parent-QObject (this?) otherwise the model would be leaked, or?



plugins/standardoutputview/standardoutputview.h
<http://git.reviewboard.kde.org/r/100666/#comment1246>

    as said above, make sure to keep the old default or use NoOptions as default value



plugins/standardoutputview/tests/standardoutputviewtest.h
<http://git.reviewboard.kde.org/r/100666/#comment1248>

    in future, maybe a test to check filtering would be good.



plugins/standardoutputview/tests/standardoutputviewtest.cpp
<http://git.reviewboard.kde.org/r/100666/#comment1247>

    I'll have to test this manually and find out why this is not working - it should not be needed...


- Milian


On Feb. 16, 2011, 2:27 p.m., Silvère Lestang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100666/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2011, 2:27 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Add to StandardOutputView plugin:
>  * An option to display or not the two buttons "Select activated Item" and "Focus when selecting Item"
>  * An optional filter action, added to "build", "run" and "debug" outputview
>  * the possibility to add a list of QAction to an outputview (the actions appears in the toolbar and the context menu)
> 
> Fix: now when we remove an output view from one Area, it's removed from all Areas
> 
> Know bug: If you remove quickly many outputs displayed in more than one Area, KDevelop crash. I can't fix the bug as I don't know where and why it's appears exactly (if I attached the debugger, KDevelop is slower so making the bug disappear).
> 
> 
> Diffs
> -----
> 
>   outputview/ioutputview.h c889003 
>   plugins/standardoutputview/CMakeLists.txt bdb23e4 
>   plugins/standardoutputview/kdevstandardoutputview.rc 5455135 
>   plugins/standardoutputview/outputwidget.h eef3844 
>   plugins/standardoutputview/outputwidget.cpp 18e35e7 
>   plugins/standardoutputview/standardoutputview.h 4f7e1bf 
>   plugins/standardoutputview/standardoutputview.cpp fbdae75 
>   plugins/standardoutputview/tests/CMakeLists.txt PRE-CREATION 
>   plugins/standardoutputview/tests/standardoutputviewtest.h PRE-CREATION 
>   plugins/standardoutputview/tests/standardoutputviewtest.cpp PRE-CREATION 
>   plugins/standardoutputview/toolviewdata.h 14afd45 
> 
> Diff: http://git.reviewboard.kde.org/r/100666/diff
> 
> 
> Testing
> -------
> 
> A test has been adding for the plugin - it's pass - but it's reimplement the macro QTEST_KDEMAIN to get round a bug that I don't understand.
> 
> 
> Thanks,
> 
> Silvère
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110217/55998659/attachment.html>