Review Request: Fix VcsEventModel::addEvents and VcsItemEventModel::addItemEvents.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100662/#review1443
-----------------------------------------------------------

Ship it!


seems to be straight forward, go ahead

- Milian


On Feb. 15, 2011, 2:58 p.m., Andrey Batyiev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100662/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2011, 2:58 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> There is a bug when user calls them (VcsEventModel::addEvents and VcsItemEventModel::addItemEvents) for a first time: inserted items have numbers from 0 to list.count()-1, not just list.count().
> (Example: list.count() = 5, items is 0,1,2,3,4).
> This produces extra empty lines in table views while viewing VCS History window.
> 
> 
> Diffs
> -----
> 
>   vcs/models/vcseventmodel.cpp 865faec 
>   vcs/models/vcsitemeventmodel.cpp fe39899 
> 
> Diff: http://git.reviewboard.kde.org/r/100662/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110215/674da85b/attachment.html>