<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100662/">http://git.reviewboard.kde.org/r/100662/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">seems to be straight forward, go ahead</pre>
<br />
<p>- Milian</p>
<br />
<p>On February 15th, 2011, 2:58 p.m., Andrey Batyiev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Andrey Batyiev.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2011, 2:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is a bug when user calls them (VcsEventModel::addEvents and VcsItemEventModel::addItemEvents) for a first time: inserted items have numbers from 0 to list.count()-1, not just list.count().
(Example: list.count() = 5, items is 0,1,2,3,4).
This produces extra empty lines in table views while viewing VCS History window.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>vcs/models/vcseventmodel.cpp <span style="color: grey">(865faec)</span></li>
<li>vcs/models/vcsitemeventmodel.cpp <span style="color: grey">(fe39899)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100662/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>