Review Request: Hide _darcs directory tree from kdevelop projects

[Filip Brcic]

> On Dec. 27, 2011, 1:59 p.m., Sven Brauch wrote:
> > I'm all for the general approach with the UI widget you suggested, as Python will need something like this too to filter out *.pyc files and similar stuff. :)
> 
> Filip Brcic wrote:
>     Ok, I've implemented that UI widget, but it had to go to kdevplatform. The settings is accessible through (I)ProjectController::filteredFiles which returns a string list. That string list is then regexp glob matched with files in the cmakeproject.cpp in kdevelop.
>     
>     Here's how the config widget now looks like in recompiled kdevplatform&kdevelop:
>     
>     https://photos-1.dropbox.com/i/l/Zfvu7jv26pTXE4Q2-ETGjRRlT2rdimyzsTcdeM1eJ_Y/844580/1325091600/6a2bae3/config_projects_w_ignored_files_live.png
>     
>     The patches are the following:
>     
>     for kdevplatform: http://dl.dropbox.com/u/844580/kdevelop-filters/kdevplatform-generic_filter-1.diff
>     
>     and for kdevelop: http://dl.dropbox.com/u/844580/kdevelop-filters/kdevelop-generic_filter-1.diff
>     
>     Since this is one change in two repositories, my question is should I open a new review request for kdevplatform or can I add both these patches to this review request?
>     
>     PS: *.pyc is not default, I just added it to my filter list to test if it actually filters new files. I also touched some file.pyc in my project tree for that purpose. But if needed it can easily be added to the default list.
> 
> Aleix Pol Gonzalez wrote:
>     Yes, you should open a reviewboard request for the new patches. Submit kdevplatform's first, so that we can discuss the API first.
>     
>     As a first read it looks good, although maybe we might want to push it a little further.

Done: https://git.reviewboard.kde.org/r/103554/


- Filip


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103549/#review9306
-----------------------------------------------------------


On Dec. 26, 2011, 11:44 p.m., Filip Brcic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103549/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2011, 11:44 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I recently worked on a C++ project that was using a darcs repository (Darcs is a distributed VCS, for more info visit darcs.net). Unfortunately for me, unlike git or mercurial, darcs is using a _darcs directory to hold all repo data, and kdevelop is filtering only hidden files (ie. those starting with a dot), so the Quick open was rendered useless as it listed tons of _darcs/something files that I certainly didn't want to edit by hand.
> 
> That's why I patched kdevelop to filter out _darcs directories. I simply added additional if in the cmakemanager.cpp file into the filterFiles function (it filtered only backup files).
> 
> I realize this cannot be a top priority to merge, but since it is an extremely minor fix, I hope you'll integrate it into kdevelop anyways.
> 
> Best regards,
> Filip
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/cmakemanager.cpp 7fd75da 
> 
> Diff: http://git.reviewboard.kde.org/r/103549/diff/diff
> 
> 
> Testing
> -------
> 
> I've compiled kdevelop with this patch on Gentoo (4.2.2 is currently stable Gentoo version, but the patch is from git tip) and now it successfully filters out _darcs directories rendering quickopen usable again.
> 
> 
> Thanks,
> 
> Filip Brcic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111227/b2843e1e/attachment.html>