<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103549/">http://git.reviewboard.kde.org/r/103549/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 27th, 2011, 1:59 p.m., <b>Sven Brauch</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm all for the general approach with the UI widget you suggested, as Python will need something like this too to filter out *.pyc files and similar stuff. :)</pre>
</blockquote>
<p>On December 27th, 2011, 5:15 p.m., <b>Filip Brcic</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I've implemented that UI widget, but it had to go to kdevplatform. The settings is accessible through (I)ProjectController::filteredFiles which returns a string list. That string list is then regexp glob matched with files in the cmakeproject.cpp in kdevelop.
Here's how the config widget now looks like in recompiled kdevplatform&kdevelop:
https://photos-1.dropbox.com/i/l/Zfvu7jv26pTXE4Q2-ETGjRRlT2rdimyzsTcdeM1eJ_Y/844580/1325091600/6a2bae3/config_projects_w_ignored_files_live.png
The patches are the following:
for kdevplatform: http://dl.dropbox.com/u/844580/kdevelop-filters/kdevplatform-generic_filter-1.diff
and for kdevelop: http://dl.dropbox.com/u/844580/kdevelop-filters/kdevelop-generic_filter-1.diff
Since this is one change in two repositories, my question is should I open a new review request for kdevplatform or can I add both these patches to this review request?
PS: *.pyc is not default, I just added it to my filter list to test if it actually filters new files. I also touched some file.pyc in my project tree for that purpose. But if needed it can easily be added to the default list.</pre>
</blockquote>
<p>On December 27th, 2011, 5:50 p.m., <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, you should open a reviewboard request for the new patches. Submit kdevplatform's first, so that we can discuss the API first.
As a first read it looks good, although maybe we might want to push it a little further.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done: https://git.reviewboard.kde.org/r/103554/</pre>
<br />
<p>- Filip</p>
<br />
<p>On December 26th, 2011, 11:44 p.m., Filip Brcic wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Filip Brcic.</div>
<p style="color: grey;"><i>Updated Dec. 26, 2011, 11:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I recently worked on a C++ project that was using a darcs repository (Darcs is a distributed VCS, for more info visit darcs.net). Unfortunately for me, unlike git or mercurial, darcs is using a _darcs directory to hold all repo data, and kdevelop is filtering only hidden files (ie. those starting with a dot), so the Quick open was rendered useless as it listed tons of _darcs/something files that I certainly didn't want to edit by hand.
That's why I patched kdevelop to filter out _darcs directories. I simply added additional if in the cmakemanager.cpp file into the filterFiles function (it filtered only backup files).
I realize this cannot be a top priority to merge, but since it is an extremely minor fix, I hope you'll integrate it into kdevelop anyways.
Best regards,
Filip</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've compiled kdevelop with this patch on Gentoo (4.2.2 is currently stable Gentoo version, but the patch is from git tip) and now it successfully filters out _darcs directories rendering quickopen usable again.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/cmake/cmakemanager.cpp <span style="color: grey">(7fd75da)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103549/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>