Review Request: Custom build system: Make multipath unittest pass

Andreas Pakulat apaku at gmx.de
Fri Dec 23 22:27:55 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103523/#review9223
-----------------------------------------------------------


Hmm, I wonder wether it might be better to compare the actual url's instead of their string-representation. Or does the test still fail when removing the .url from both sides?

- Andreas Pakulat


On Dec. 23, 2011, 10:12 p.m., Morten Volden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103523/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2011, 10:12 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Make multipath unittest pass
> 
> 
> Diffs
> -----
> 
>   tests/custombuildsystemplugintest.cpp ab2c861 
> 
> Diff: http://git.reviewboard.kde.org/r/103523/diff/diff
> 
> 
> Testing
> -------
> 
> The test now passes
> 
> 
> Thanks,
> 
> Morten Volden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111223/2a3ac270/attachment.html>


More information about the KDevelop-devel mailing list