Review Request: Add Progress Support for Git Clone Job

[David Narváez]

> On Dec. 10, 2011, 9:50 p.m., Aleix Pol Gonzalez wrote:
> > You should check why isn't the ::processResult code doing this, because it's meant to provide this information. If it's not correctly done, this code should be removed, but we don't want two codes to track the progress.

I don't think the purpose of processResult() is handling progress because it calls the error() method, which is meant to be called only at the end of the job. It does include some error handling just to provide the last percentage value when error occurs. How do you see we could merge those methods?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103380/#review8865
-----------------------------------------------------------


On Dec. 10, 2011, 8:55 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103380/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2011, 8:55 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Very naive approach to leverage stderr to get progress. I'm no expert on QProcesses so if anything looks bad or the idea is bad as a whole, just let me know.
> 
> 
> This addresses bug 256832.
>     http://bugs.kde.org/show_bug.cgi?id=256832
> 
> 
> Diffs
> -----
> 
>   plugins/git/gitclonejob.h 3279ba1 
>   plugins/git/gitclonejob.cpp ce48ee7 
> 
> Diff: http://git.reviewboard.kde.org/r/103380/diff/diff
> 
> 
> Testing
> -------
> 
> 1. Fetch a large project using the Git provider (I tried NetworkManager, for instance)
> 2. Fetch a project using the KDE provider
> 
> In both tests, before this patch, progress is not changed until the project is completely fetched (see bug 256832). After this patch, progress bar changes with the standard error. Notice that the bar is filled three times, I'm not sure how to avoid that without making the code overly complex, but I thought it was a nice start to at least have the progress in the critical part of the process which is the second time the progress bar fills (downloading objects).
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20111210/43067b85/attachment.html>