Review Request: Fix installing from kdevelop when multiple jobs allowed (bug 264893)

Guillaume de Bure guillaume.debure at gmail.com
Mon Apr 25 21:05:45 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101226/
-----------------------------------------------------------

(Updated April 25, 2011, 9:05 p.m.)


Review request for KDevelop.


Changes
-------

Instead of moving the -j4 option at the end of the command line, simply replace the -c switch by --.

Simplest. Patch. Ever.


Summary
-------

it looks like the command "kdesu -t -c make -j4 install" called when installing from kdevelop doesn't work. Moving the -j option to the end of the command seems to work:
"kdesu -t -c make install -j4". This extremely simple patch does this.

Since I don't have a good knowledge of kdevelop's code, I don't know if this move can have other side effects...

Thanks :)


This addresses bug 264893.
    http://bugs.kde.org/show_bug.cgi?id=264893


Diffs (updated)
-----

  projectbuilders/makebuilder/makejob.cpp b98bf07 

Diff: http://git.reviewboard.kde.org/r/101226/diff


Testing
-------

Works for me (tm)


Thanks,

Guillaume

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110425/f1f7dd64/attachment.html>


More information about the KDevelop-devel mailing list