Review Request: Fix installing from kdevelop when multiple jobs allowed (bug 264893)

[Aleix Pol Gonzalez]

> On April 25, 2011, 11:39 a.m., Milian Wolff wrote:
> > how come it does not work for you? what make are you using?
> > 
> > I just checked and this works both fine for me:
> > 
> > make install -j 10
> > make -j 10 install
> >
> 
> Andreas Pakulat wrote:
>     Did you try including the kdesu? Maybe that makes the difference. Can't test here as I don't have kdesu.
> 
> Guillaume de Bure wrote:
>     Indeed, my bug is with kdesu: this is what fits in my workflow. Does this patch break alternatives ?

Well, Guillaume, you should make sure where the problem is exactly so that we don't make changes where it isn't the appropiate place.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101226/#review2885
-----------------------------------------------------------


On April 24, 2011, 2:14 p.m., Guillaume de Bure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101226/
> -----------------------------------------------------------
> 
> (Updated April 24, 2011, 2:14 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> it looks like the command "kdesu -t -c make -j4 install" called when installing from kdevelop doesn't work. Moving the -j option to the end of the command seems to work:
> "kdesu -t -c make install -j4". This extremely simple patch does this.
> 
> Since I don't have a good knowledge of kdevelop's code, I don't know if this move can have other side effects...
> 
> Thanks :)
> 
> 
> This addresses bug 264893.
>     http://bugs.kde.org/show_bug.cgi?id=264893
> 
> 
> Diffs
> -----
> 
>   projectbuilders/makebuilder/makejob.cpp b98bf07 
> 
> Diff: http://git.reviewboard.kde.org/r/101226/diff
> 
> 
> Testing
> -------
> 
> Works for me (tm)
> 
> 
> Thanks,
> 
> Guillaume
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110425/086aab9b/attachment.html>