Review Request: Implement per project editor settings

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101028/#review2392
-----------------------------------------------------------


a few things:

a) remove trailing whitespaces
b) remove useless kdebug output
c) if it depends on a kate patch, make sure this new feature is only enabled when this patch is available. as there is no good check for this, you'll have to check for the next KDE version that will include your kate patch
d) I don't like the complexity of the approach. you'll have to find a setting in one config dialog, then open the other one again - very unintuitive imo...
Though I cannot really come up with a better approach. Would it maybe be possible to add "project-specific editor settings" or something as a direct action below "project configuration" or something like that?
e) I'd like to see some unit tests for that.

- Milian


On April 5, 2011, 1:44 a.m., Spencer Jackson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101028/
> -----------------------------------------------------------
> 
> (Updated April 5, 2011, 1:44 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This patch adds support for having different editor configuration settings for different projects. This works by adding a configuration option which enables an editor settings override for a specific project. When this setting is enabled, editor configuration settings will be loaded from the project configuration, rather than the kdevelop configuration. When documents are changed, the configuration will be refreshed, allowing the editor settings to change between projects.
> Note: While I was writing this, I noticed that Kate would save the configuration settings to the kdevelop configuration file during configDialog(). This was not desirable behaviour, as I couldn't prevent projects using that config from getting clobbered. Further, it broke the documented spec. I documented this in bug #270122, and have submitted a patch to Kate for review.
> 
> 
> This addresses bugs 249194 and 270122.
>     http://bugs.kde.org/show_bug.cgi?id=249194
>     http://bugs.kde.org/show_bug.cgi?id=270122
> 
> 
> Diffs
> -----
> 
>   project/CMakeLists.txt a5b7f74 
>   project/kcm_kdev_projecteditorsettings.desktop PRE-CREATION 
>   project/projecteditorsettings.h PRE-CREATION 
>   project/projecteditorsettings.cpp PRE-CREATION 
>   project/projecteditorsettings.ui PRE-CREATION 
>   project/projectoverrides.kcfg PRE-CREATION 
>   project/projectoverrides.kcfgc PRE-CREATION 
>   shell/documentcontroller.h 95b5dd7 
>   shell/documentcontroller.cpp 1b4c560 
>   shell/mainwindow_actions.cpp e0610e9 
> 
> Diff: http://git.reviewboard.kde.org/r/101028/diff
> 
> 
> Testing
> -------
> 
> Enabled the override in kdevplatform. Opened a file from that project. Enabled a setting in the editor. Stepped into a file opened from kdevelop. Checked if setting was enabled. Enabled another setting. Stepped back into kdevplatform. Check if setting was disabled.
> 
> 
> Thanks,
> 
> Spencer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110405/bb9d93b3/attachment.html>