<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101028/">http://git.reviewboard.kde.org/r/101028/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a few things:
a) remove trailing whitespaces
b) remove useless kdebug output
c) if it depends on a kate patch, make sure this new feature is only enabled when this patch is available. as there is no good check for this, you'll have to check for the next KDE version that will include your kate patch
d) I don't like the complexity of the approach. you'll have to find a setting in one config dialog, then open the other one again - very unintuitive imo...
Though I cannot really come up with a better approach. Would it maybe be possible to add "project-specific editor settings" or something as a direct action below "project configuration" or something like that?
e) I'd like to see some unit tests for that.</pre>
<br />
<p>- Milian</p>
<br />
<p>On April 5th, 2011, 1:44 a.m., Spencer Jackson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Spencer Jackson.</div>
<p style="color: grey;"><i>Updated April 5, 2011, 1:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds support for having different editor configuration settings for different projects. This works by adding a configuration option which enables an editor settings override for a specific project. When this setting is enabled, editor configuration settings will be loaded from the project configuration, rather than the kdevelop configuration. When documents are changed, the configuration will be refreshed, allowing the editor settings to change between projects.
Note: While I was writing this, I noticed that Kate would save the configuration settings to the kdevelop configuration file during configDialog(). This was not desirable behaviour, as I couldn't prevent projects using that config from getting clobbered. Further, it broke the documented spec. I documented this in bug #270122, and have submitted a patch to Kate for review.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Enabled the override in kdevplatform. Opened a file from that project. Enabled a setting in the editor. Stepped into a file opened from kdevelop. Checked if setting was enabled. Enabled another setting. Stepped back into kdevplatform. Check if setting was disabled.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=249194">249194</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=270122">270122</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>project/CMakeLists.txt <span style="color: grey">(a5b7f74)</span></li>
<li>project/kcm_kdev_projecteditorsettings.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>project/projecteditorsettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>project/projecteditorsettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>project/projecteditorsettings.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>project/projectoverrides.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>project/projectoverrides.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/documentcontroller.h <span style="color: grey">(95b5dd7)</span></li>
<li>shell/documentcontroller.cpp <span style="color: grey">(1b4c560)</span></li>
<li>shell/mainwindow_actions.cpp <span style="color: grey">(e0610e9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101028/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>