Review Request: Fix crash when KTextEdit::Factory is not found

[Robert Mathias Marmorstein]

> On April 4, 2011, 9:04 a.m., Milian Wolff wrote:
> > looks good now, I prefferr it that way. but I wonder - return code -1? shouldn't it be an int between 1 and 255?

The exit status actually gets bitwise anded with the octal value 377, so both -1 and 1 return non-zero.  The -1 exit status is a standard for some projects (linux kernel?  I forget), while an exit status of "1" is also often used in Unix.  Ordinarily it doesn't matter, but using either of the numeric values can cause portability issues.  The new standard is to use "EXIT_SUCCESS" and "EXIT_FAILURE" macros to be more portable, so I have changed the code to use "EXIT_FAILURE", tested (it works), and committed.

Thanks!


- Robert Mathias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100949/#review2379
-----------------------------------------------------------


On April 4, 2011, 7:35 a.m., Robert Mathias Marmorstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100949/
> -----------------------------------------------------------
> 
> (Updated April 4, 2011, 7:35 a.m.)
> 
> 
> Review request for KDevelop and Quanta.
> 
> 
> Summary
> -------
> 
> This patch fixes a crash which occurs when closing kdevelop or quanta after the "KTextEditor::Factory not found" error box is displayed.  The problem is a simple logic error caused by the fact that QApplicationCore::exit() does not immediately abort an application.  Instead, it causes event processing to cease, which indirectly terminates the application AFTER the function has returned to the main event loop.
> 
> 
> Diffs
> -----
> 
>   shell/partcontroller.cpp 5a81de0 
> 
> Diff: http://git.reviewboard.kde.org/r/100949/diff
> 
> 
> Testing
> -------
> 
> Recompiled, ran quanta and kdevelop.  Error message dialog still comes up (as it should), but the program closes without crashing now.
> 
> 
> Thanks,
> 
> Robert Mathias
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20110404/d447bc8a/attachment.html>