Request for review: Okteta plugin 0.1.0 for KDevelop 4.0

[Friedrich W. H. Kossebau]

Mercredi, le 1 septembre 2010, à 22:16, Friedrich W. H. Kossebau a écrit:
> Lundi, le 30 août 2010, à 21:41, Andreas Pakulat a écrit:
> > On 26.08.10 02:19:41, Friedrich W. H. Kossebau wrote:
> > > Jeudi, le 26 août 2010, à 02:05, Andreas Pakulat a écrit:
> > > > On 25.08.10 21:48:02, Friedrich W. H. Kossebau wrote:
> > > > > Mardi, le 24 août 2010, à 20:40, Andreas Pakulat a écrit:
> > > > Maybe its style-related or fixed in trunk
> > > > already? (I'm running a 3-week old trunk here currently)
> > > 
> > > Guess it's a problem with the font, seems to have bad info about width
> > > (so calculation goes wrong). Can you try with another font?
> > 
> > FWIW: The font with that size works just fine everywhere else (konsole,
> > kate, webpages). Its Dejavu Sans Mono, size 8. If I change to size 7 the
> > grey background is larger than the text itself. If I change the font to
> > 11 or so the background grows properly with it. Still weird that it only
> > breaks in that view...
> 
> All others might not write char by char to their offsets, like Okteta does,
> but render whole strings (e.g. Konsole does, where Qt (or whoever) fall
> back to a proportional font for me and left me wondering for a while why
> the cursor (offset computed differently obviously) was in such a distance
> to the last character, until I found out.
> Should take a look at the offset calculation of Konsole perhaps, seems not
> to fail here.
> Thanks for the hint, always blamed the font before :P

For the record:
Should be fixed now both in 4.5 branch and trunk, now uses whole string to 
calculate width, not just one digit (which gets rounded to full pixel count, 
so multiplying gets wrong values, bah, why does QFontMetrics::maxWidth() 
deliver pixel number at all...).

> > I've also noticed that the widget doesn't update the font when I click
> > on the apply button in systemsettings (normally apps update their
> > font-rendering). Is that known to you?

Oh, seems not all do, e.g. Konsole ignores (unless I did not find something 
like "Use system font").
But still this effect would be wanted for Okteta, as there is no other way to 
adjust the font used.

> Yes, it is, but thanks. TODO for a long time, in mind at least :)

No longer, commited a fix and backported it (so is in 4.5.2).
Just doesn't play nicely if the view is not at 100 % zoom. No idea how to fix 
that with the current code. Zooming should be done differently in the future 
anyway, so might not fix that.
Hm, forgot about all the tool tables which also use a fixed font, need to do a 
fix to them tomorrow, then, too.

Cheers
Friedrich
-- 
KDE Okteta - a simple hex editor - http://utils.kde.org/projects/okteta