[PATCH] C++ preprocessor fixes

Milian Wolff mail at milianw.de
Sat Nov 27 21:53:03 UTC 2010

On Saturday 27 November 2010 22:37:20 Dmitry Risenberg wrote:
> > Feel free to push the patch (I think Dmitry has write access, no?)
> It seems to me that every developer has write access, because I saw
> the repository as read-writable as soon as I got my developer account.
> > @Dmitry: Did you request your KDE account yet? If not, do that and push
> > yourself in the future, awesome work.
> I did get it, but I'd prefer my code to be reviewed, because I'm not
> sure I do everything the right way. I tried sending to the
> reviewboard, but kdevelop project wasn't registered there (told Aleix
> about that), so the patch ended up in the mailing list.

Oh, sorry - then you could have pushed that on your own (and should do that in 
future, I won't be over-fast the next time :)).

> > noo, just saw that I forgot to attribute you in the commit message - I'm
> > sorry!
> It's OK. You could do "git am <patch-file" in your local repository
> and push it, then all the history would be preserved.

ah, I used "apply" - didn't know of am yet. Will use that in the future. Sorry 

Bye, have a nice weekend
Milian Wolff
mail at milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101127/8d31015c/attachment.sig>

More information about the KDevelop-devel mailing list