[PATCH] C++ preprocessor fixes

Dmitry Risenberg dmitry.risenberg at gmail.com
Sat Nov 27 21:37:20 UTC 2010

> Feel free to push the patch (I think Dmitry has write access, no?)

It seems to me that every developer has write access, because I saw
the repository as read-writable as soon as I got my developer account.

> @Dmitry: Did you request your KDE account yet? If not, do that and push
> yourself in the future, awesome work.

I did get it, but I'd prefer my code to be reviewed, because I'm not
sure I do everything the right way. I tried sending to the
reviewboard, but kdevelop project wasn't registered there (told Aleix
about that), so the patch ended up in the mailing list.

> noo, just saw that I forgot to attribute you in the commit message - I'm
> sorry!

It's OK. You could do "git am <patch-file" in your local repository
and push it, then all the history would be preserved.

Dmitry Risenberg

More information about the KDevelop-devel mailing list