[PATCH] makebuilder: kdesudo install fix

Milian Wolff mail at milianw.de
Sat Nov 20 19:17:00 UTC 2010


On Saturday 20 November 2010 11:13:57 Tim Blechmann wrote:
> when using parallel builds, make install with kdesudo uses a command string
> like:
> kdesudo -t -c make -j4 install
> 
> this fails, since -j4 is interpreted as argument to kdesudo, but not to
> make. this patch changes the kdesudo command string to
> 
> kdesudo -t -- make -j4 install
> 
> Signed-off-by: Tim Blechmann <tim at klingt.org>
> ---
>  projectbuilders/makebuilder/makejob.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/projectbuilders/makebuilder/makejob.cpp
> b/projectbuilders/makebuilder/makejob.cpp index eaf7074..a638cc9 100644
> --- a/projectbuilders/makebuilder/makejob.cpp
> +++ b/projectbuilders/makebuilder/makejob.cpp
> @@ -228,7 +228,7 @@ QStringList MakeJob::computeBuildCommand() const
>          QString suCommandName;
>          if (suCommand == 1) {
>            suCommandName = "kdesudo";
> -          arguments << "-t" << "-c" << cmdline;
> +          arguments << "-t" << "--" << cmdline;
>          } else if (suCommand == 2) {
>            suCommandName = "sudo";
>            arguments << cmdline;

Pushed, thanks
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101120/f3696bdb/attachment-0001.sig>


More information about the KDevelop-devel mailing list