MovingRanges Port: untitled documents

David Nolden zwabel at googlemail.com
Fri Jul 23 12:22:04 UTC 2010


2010/7/22 Milian Wolff <mail at milianw.de>:
>> > Problem:
>> > KDevelop::Document::url() == 'Untitled'; == valid
>> > TextDocument::url() == "" != valid
>> >
>> > => assert
>> >
>> > now I thought, fine lets add checks for validity before creating the
>> > tracker, but is that what we want? Why is there a tracker at all for a
>> > document for which no language exists? I'd like some feedback before I
>> > start "fixing" stuff to make it work.
>>
>> PS: Shouldn't document renames (i.e. urlChanged) be tracked in the
>> background parser?

Ideally yes, but for now we'd go for the simplest solution.

> - crash on document reload (see long thread on kwrite ml)
Stays on my todo.

> - deadlock on assistant (see this ml)
Fixed.

> And I generally percieve it to be "slower", i.e. more sluggish. Looks like
> I'll have to do a lot more profiling after GSOC ;-)
There was a problem in the highlighting-code that created more and
more highlighting ranges without deleting old ones, which might be a
possible reason for this. This also fixes the issue that the
highlighting sometimes stayed after code became invalid/commented.

Greetings, David




More information about the KDevelop-devel mailing list