seamless project model update
aleixpol at kde.org
Mon Jul 12 12:33:10 UTC 2010
On Mon, Jul 12, 2010 at 2:23 PM, Milian Wolff <mail at milianw.de> wrote:
> On Monday, 12. July 2010 04:46:26 Aleix Pol wrote:
> > hi,
> > This patch solves the problem we have when we try to refresh the
> > projectmodel from another thread, it makes the method call to be
> > whenever the model thread runs the event loop. I know it's not a clean
> > implementation (that's why I'm sending it here).
> > I'm sending a patch so that you can try how the reload feels after that
> > change. I'm not commiting right away because I understand there's
> > and I suppose you will want to give your opinion. I think we could give
> > a try though.
> Shouldn't the check go into appendRow itself? Instead of the ctor of the
Well, I put that in the ctor because it's there when you just create the
file and don't care anymore. When you do an appendrow you might want to
check it after (and of course it will result in a problem, since the
addition is delayed). I'm fine with creating a delayedAppendRow or something
like that, though.
> Does it work with Generic Manager as well?
Haven't tried but it should. It should work the same as long as you add
items from the main (model's) thread.
> Have you tried showing the project root item directly upon starting the
> job, which used to show the problems for me back then in cmake manager? Imo
> this should work with your patch then?
This should probably work, yes. Haven't tried though.
And I still think the user will like to have some feedback on the project
imported (maybe not being actually capable to work on the project but
> And: Even though it looks a bit hackish, I'm all in favor. Simply because
> user impression will get much better.
It is hackish but considering than working from another thread is just
broken, I think we should consider using it (or twisting the API a little
> Milian Wolff
> mail at milianw.de
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the KDevelop-devel