seamless project model update

[Andreas Pakulat]

On 12.07.10 04:46:26, Aleix Pol wrote:
> hi,
> This patch solves the problem we have when we try to refresh the
> projectmodel from another thread, it makes the method call to be triggered
> whenever the model thread runs the event loop. I know it's not a clean
> implementation (that's why I'm sending it here).
> 
> I'm sending a patch so that you can try how the reload feels after that
> change. I'm not commiting right away because I understand there's drawbacks
> and I suppose you will want to give your opinion. I think we could give it a
> try though.

I can't say too much about the cmake-part of the patch.

Apart from that, 

> diff --git a/project/projectmodel.cpp b/project/projectmodel.cpp
> index 8700e11..ac7a662 100644
> --- a/project/projectmodel.cpp
> +++ b/project/projectmodel.cpp
> @@ -108,7 +109,6 @@ public:
>      KUrl m_url;
>  };
>  
> -
>  ProjectBaseItem::ProjectBaseItem( IProject* project, const QString &name, ProjectBaseItem *parent )
>          : d_ptr(new ProjectBaseItemPrivate)
>  {
> @@ -116,7 +116,16 @@ ProjectBaseItem::ProjectBaseItem( IProject* project, const QString &name, Projec
>      d->project = project;
>      d->text = name;
>      if( parent ) {
> -        parent->appendRow( this );
> +        qDebug() << "---" << parent->model();
> +        if(!parent->model() /*|| QThread::currentThread()==parent->model()->thread()->currentThread()*/) {
> +            qDebug() << "A";
> +            parent->appendRow(this);
> +        } else {
> +            qDebug() << "B";
> +            bool ret=QMetaObject::invokeMethod(parent->model(), "appendRow", Qt::QueuedConnection,
> +                                               Q_ARG(void*, parent), Q_ARG(void*, this));
> +            Q_ASSERT(ret);
> +        }

This looks wrong, there shouldn't be a difference based on wether an
item is in the model or not. The check should be wether
QThread::currentThread == qApp->thread(), i.e. wether the function is
called from the main thread or not.

And last but not least: This doesn't make the model threadsafe at all,
so IMHO this shouldn't be done as its confusing that one part makes an
attempt to be threadsafe, but all others are still broken in that
regard.

> +void ProjectModel::appendRow(void* parent, void* item)
> +{
> +    static_cast<ProjectBaseItem*>(parent)->appendRow(static_cast<ProjectBaseItem*>(item));
> +}

Why using void* here? It should be fine to use the actual types no?

Andreas

-- 
You need no longer worry about the future.  This time tomorrow you'll be dead.