extragear/sdk/kdevplatform/plugins/genericprojectmanager

[Milian Wolff]

On Thursday, 28. January 2010 09:42:10 Andreas Pakulat wrote:
> On 28.01.10 02:40:40, Milian Wolff wrote:
> > SVN commit 1081271 by mwolff:
> >
> > remove obsolete api (the signals are defined in the interface), mark an
> > arg as unused
> 
> Uhm, they're declared there, but AFAIK that won't work. The interface
> doesn't (and cannot) inherit from QObject and has no Q_OBJECT macro,
> hence moc doesn't generate signal-code for it. So thats why you have to
> duplicate  the signals on the manager.
> 
> For some VCS signals (IIRC and KTE also does this), the signals are pure
> virtual functions without the Q_SIGNALS macro. That way the subclasses
> _have to_ declare and implement (via the .moc file) those and they're
> still visible in the public interface for documentation purposes.

OK, thanks for the clarification. Should I:

- revert the commit and emit the Signals where appropriate? This is not done 
so far and afaik there is also nothing listening to these signals. Do we 
really need them?

- also remove the Signals from the interface and every other implementation

> >  M  +0 -10     genericmanager.h
> >  M  +1 -0      genericmanagerlistjob.cpp
> >
> >
> > ---
> > trunk/extragear/sdk/kdevplatform/plugins/genericprojectmanager/genericman
> >ager.h #1081270:1081271 @@ -82,15 +82,6 @@
> >      typedef QPair<QStringList, QStringList> IncludeRules;
> >
> >  Q_SIGNALS:
> > -    void folderAdded( KDevelop::ProjectFolderItem* folder );
> > -    void folderRemoved( KDevelop::ProjectFolderItem* folder );
> > -    void folderRenamed( const KUrl& oldFolder,
> > -                        KDevelop::ProjectFolderItem* newFolder );
> > -
> > -    void fileAdded(KDevelop::ProjectFileItem* file);
> > -    void fileRemoved(KDevelop::ProjectFileItem* file);
> > -    void fileRenamed(const KUrl& oldFile,
> > -                     KDevelop::ProjectFileItem* newFile);
> >      void appendSubDir( KDevelop::ProjectFolderItem* item );
> >
> >  private Q_SLOTS:
> > @@ -112,7 +103,6 @@
> >      bool isValid( const KUrl& url, const bool isFolder,
> > KDevelop::IProject* project, const IncludeRules& rules ) const;
> >      QMap<KDevelop::IProject*, KDirWatch*> m_watchers;
> > -    QMap<KIO::Job*, KDevelop::IProject*> m_jobProjects;
> >  };
> >
> >  #endif // KDEVGENERICIMPORTER_H
> > ---
> > trunk/extragear/sdk/kdevplatform/plugins/genericprojectmanager/genericman
> >agerlistjob.cpp #1081270:1081271 @@ -58,6 +58,7 @@
> >
> >  void GenericManagerListJob::slotEntries(KIO::Job* job, const
> > KIO::UDSEntryList& entriesIn) {
> > +    Q_UNUSED(job);
> >      entryList.append(entriesIn);
> >  }
> 

-- 
Milian Wolff
mail at milianw.de
http://milianw.de