Review Request: fixed one unwanted appearance of autocompletion list, e.g in a place like "#include <iostream>::"

Milian Wolff mail at milianw.de
Thu Jan 7 19:41:57 UTC 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2523/#review3603
-----------------------------------------------------------


you should honor the code style, i.e. use spaces instead of tabs for indendation.

other than that looks fine, but I dunno how useful it is (I'd personally never insert a :: in a #include line, but maybe it's useful for other places...)
but i think it will still fail on something (rather unusual) like

#include \
  <foobar>::

- Milian


On 2010-01-07 19:30:58, Ishan Jayawardena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2523/
> -----------------------------------------------------------
> 
> (Updated 2010-01-07 19:30:58)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> the auto completion list appears in some places, that are not very appropriate. For an example if I type #include <iostream>:: or #include <iostream::, still the auto completion list appears. This may sound funny (no one would type like that), but I believe that it should not be there if auto completion is supposed to work correctly. So I tried to fix it.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/sdk/kdevelop/languages/cpp/codecompletion/model.cpp 1062134 
> 
> Diff: http://reviewboard.kde.org/r/2523/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ishan
> 
>





More information about the KDevelop-devel mailing list