Review Request: Find in Files in context menu

Milian Wolff mail at milianw.de
Sat Feb 27 18:48:18 UTC 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3072/#review4310
-----------------------------------------------------------

Ship it!


remove the one line and imo also adapt the action label. Other than that works like a charm, thanks! Please commit.


trunk/extragear/sdk/kdevplatform/plugins/grepview/grepviewplugin.cpp
<http://reviewboard.kde.org/r/3072/#comment3800>

    shouldn't the text be "Find Selection In Files"? Not sure



trunk/extragear/sdk/kdevplatform/plugins/grepview/grepviewplugin.cpp
<http://reviewboard.kde.org/r/3072/#comment3799>

    you apparently don't need this line at all


- Milian


On 2010-02-26 23:34:52, Roman Byshko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3072/
> -----------------------------------------------------------
> 
> (Updated 2010-02-26 23:34:52)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This patch add the possibility to perform Find in Files action from the context menu after selecting some text. See screenshot.
> 
> 
> Diffs
> -----
> 
>   trunk/extragear/sdk/kdevplatform/plugins/grepview/grepviewplugin.h 1096591 
>   trunk/extragear/sdk/kdevplatform/plugins/grepview/grepviewplugin.cpp 1096591 
> 
> Diff: http://reviewboard.kde.org/r/3072/diff
> 
> 
> Testing
> -------
> 
> It works for me!
> 
> 
> Screenshots
> -----------
> 
> Find in Files in Context Menu
>   http://reviewboard.kde.org/r/3072/s/324/
> 
> 
> Thanks,
> 
> Roman
> 
>





More information about the KDevelop-devel mailing list