Patch-review changes

[Andreas Pakulat]

On 21.02.10 15:17:26, David Nolden wrote:
> I've tried out the changes to the patch-review now. Unfortunately, Aleix, it 
> _stilll:_ doesn't work properly.
> 
> I've written you an extensive (though short) list in my last email of how the 
> stuff is supposed to work. Unfortunately this still isn't the case.
> 
> I find this very frustrating, because I've already had the patch-review 
> working perfectly once

Certainly not, last two times I tried it it just crashed (thats been
before christmas though)

>, and now it seems like it's up to make to make it work 
> properly for a second time. I won't do this though, since you still haven't 
> explained to my why _exactly_ all these changes are really required.

As far as I understood they were needed to make git work, additionally
we had a fork of libdiff2 which nobody maintained or tried to merge back
with the maintained original library. Thats not an acceptable situation
for a plugin we ship.

> All in all, I've alrady wasted far too much time with this. In half of the 
> time I wasted testing the patch-review changes, I could have made the old 
> patch-review work with git patches, which was the original motivation of this.

But you didn't do it and Aleix stepped up and tried to make it work,
even tried to fix this broken situation with an unmaintained
library-fork.

> I hope you don't mind too much if I revert to the old patch-review now, and 
> take another path to make it support git patches.

I do mind, either make it work with a libdiff2 that has no or only
minimal changes to "upstream" or leave the fixing to others and revert
it locally if you need to work with it.

Andreas

-- 
Fine day to work off excess energy.  Steal something heavy.