Review Request: Check for possible unloading of version control plugin in ProjectPrivate.

[Floris Ruijter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100225/#review605
-----------------------------------------------------------


i'd say it should be a shared pointer, since the plugin will now be almost immediately after the assignment be deleted, since weakpointer has no assignment from T* so it is assigned a coerced T* to sharedpointer, wich will delete the contents afterwards (very soon) then you have quite some lines down a use of the data() member which is not a member of weakpointer, but is of sharedpointer.

- Floris


On 2010-12-21 13:05:24, Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100225/
> -----------------------------------------------------------
> 
> (Updated 2010-12-21 13:05:24)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Summary
> -------
> 
> Store a QWeakPointer to version control plugin in ProjectPrivate, so that it can track deletion.
> No checking for FileManager unloading, because it seems to be a mandatory plugin.
> 
> 
> Diffs
> -----
> 
>   shell/project.cpp c8fbc53 
> 
> Diff: http://git.reviewboard.kde.org/r/100225/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101223/b010be38/attachment.html>