[KDevPlatform/1.2] 5774a52: Check that git is installed when loading Git Suppo

[Dmitry Risenberg]

2010/12/20 Aleix Pol <aleixpol at kde.org>:
> On the other hand, plugins can be unloaded by the user and we have to be
> prepared for that.

Yes, but here we crash because of unloading a plugin right in the
process of loading it - a user cannot do anything like that, so this
crash is unrelated to unloading plugins by user.
Still, I did find a bug in plugin-using code - see
http://git.reviewboard.kde.org/r/100225/ for details.

2010/12/20 Morten Volden <mvolden2 at gmail.com>:
> Hi
>
> The plugin fails due to the two lines below in the constructor of GitPlugin
> (and the fact that git is not installed on the host machine) - correct?:
>
>     DVcsJob* versionJob = new DVcsJob(QDir::tempPath(), this,
> KDevelop::OutputJob::Silent);
>     *versionJob << "git" << "--version";
>
> As far as I can tell the output of the versionJob is only used in the
>
> status(const KUrl::List& localLocations,
> KDevelop::IBasicVersionControl::RecursionMode recursion)
>
> function.
>
> Why not wait with creating a versionJob untill the status function is
> called? (And then of course only create and parse it the first time).
>
> That should solve the problem described in
> https://bugs.kde.org/show_bug.cgi?id=257650
>
> Just my 2 cents:
>
> Regards
>
> Morten

This will fix it, but the non-working Git plugin will still be loaded
and pollute the context menu.

-- 
Dmitry Risenberg