Review Request: Disable git plugin if git is not installed in the system.

Milian Wolff mail at milianw.de
Fri Dec 17 21:39:13 UTC 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100216/#review568
-----------------------------------------------------------

Ship it!


looks good, thanks please merge into 4.2

- Milian


On 2010-12-17 21:32:29, Dmitry Risenberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100216/
> -----------------------------------------------------------
> 
> (Updated 2010-12-17 21:32:29)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> https://bugs.kde.org/show_bug.cgi?id=257650
> 
> 
> This addresses bug 257650.
>     http://bugs.kde.org/show_bug.cgi?id=257650
> 
> 
> Diffs
> -----
> 
>   interfaces/iplugin.h 508a92f40a94e17178e1ec697f18f13139ab83bd 
>   interfaces/iplugin.cpp 5d14247ea87f61963e5e0875d8a908f6afd86200 
>   plugins/git/gitplugin.h de40d50395af0d5c214ec0280bb1821ffdd46734 
>   plugins/git/gitplugin.cpp c149a5055a7bb123e5a6ee0be67f40b7e6bf6a6b 
>   shell/plugincontroller.cpp 15f5c553cc6b5adce6403c726e03fb36957474ba 
>   shell/settings/pluginpreferences.cpp edb42903ecb1cd933b54357a46e633c763727197 
> 
> Diff: http://git.reviewboard.kde.org/r/100216/diff
> 
> 
> Testing
> -------
> 
> Manually tested enabling/disabling git plugin while git was removed and then installed back.
> 
> 
> Thanks,
> 
> Dmitry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101217/e919eb92/attachment.html>


More information about the KDevelop-devel mailing list