<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100216/">http://git.reviewboard.kde.org/r/100216/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good, thanks please merge into 4.2</pre>
<br />
<p>- Milian</p>
<br />
<p>On December 17th, 2010, 9:32 p.m., Dmitry Risenberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Dmitry Risenberg.</div>
<p style="color: grey;"><i>Updated 2010-12-17 21:32:29</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">https://bugs.kde.org/show_bug.cgi?id=257650</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manually tested enabling/disabling git plugin while git was removed and then installed back.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=257650">257650</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/iplugin.h <span style="color: grey">(508a92f40a94e17178e1ec697f18f13139ab83bd)</span></li>
<li>interfaces/iplugin.cpp <span style="color: grey">(5d14247ea87f61963e5e0875d8a908f6afd86200)</span></li>
<li>plugins/git/gitplugin.h <span style="color: grey">(de40d50395af0d5c214ec0280bb1821ffdd46734)</span></li>
<li>plugins/git/gitplugin.cpp <span style="color: grey">(c149a5055a7bb123e5a6ee0be67f40b7e6bf6a6b)</span></li>
<li>shell/plugincontroller.cpp <span style="color: grey">(15f5c553cc6b5adce6403c726e03fb36957474ba)</span></li>
<li>shell/settings/pluginpreferences.cpp <span style="color: grey">(edb42903ecb1cd933b54357a46e633c763727197)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100216/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>