ProjectModel: should ProjectBaseItem::text() be equal to ::baseName() ?

[Milian Wolff]

Aleix Pol, 15.12.2010:
> On Tue, Dec 14, 2010 at 11:54 PM, Milian Wolff <mail at milianw.de> wrote:
> > Hey all,
> > 
> > I wonder whether the ProjectBaseItem api is good the way it is. I esp.
> > wonder
> > whether it should be allowed to setText().
> > 
> > Personally I think that this is nowhere used and that only setUrl() is
> > used (or the CTor arguments for the name).
> > 
> > Furthermore there is already code (esp. in CMakeManager) that expects
> > text()
> > == baseName().
> > 
> > I've just added a caching baseName() for speedup
> > (http://rpi.edu/~doriad/callgrind.tar.bz2) but wonder whether that is not
> > maybe overkill. I'd like to remove it again and just reuse text()
> > instead.
> > 
> > Bye

> Makes sense to me. A patch with the proposed changes would be nice :)

Essentially just revert most of c1871ac080a8903220320d4b878b223a2168e108 by 
using d->m_text instead of d->m_baseName. And then make setText deprecated or 
remove it alltogether.

If you think it's a good idea I'll provide a patch later.

Bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101215/c960c73d/attachment.sig>