Remove flicker and don't select first view on tab close

Milian Wolff mail at milianw.de
Thu Dec 2 22:21:59 UTC 2010


On Wednesday 24 November 2010 12:42:08 Milian Wolff wrote:
> David Nolden, 24.11.2010:
> > The patch looks nice, too nice. ;-) This for sure wasn't possible when
> > the code was introduced, but maybe some of my changes made this safe
> 
> Don't get this wrong, but it might also be my refactoring. I did lots of
> fixing for the view mess-ups resulting in e.g. close all not working
> anymore. Maybe that also fixed this.
> 
> > (there might be some significant problems that you didn't notice yet,
> > for example with the tracking of open views in the working set, when
> > the same working-set is in multiple windows, etc). I need to review
> > this thoroughly, but have no time right now.
> 
> We don't support multiple windows. Do you mean areas? I checked that,
> worked like a charm for me.
> 
> Please, take the time and review it, I want this patch to go in if possible
> and remove the addViewSilent thingy as that is simply a hack in my eyes.

I've pushed this now, didn't notice any bugs myself for over a week.

Bye
-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20101202/d573b0c3/attachment.sig>


More information about the KDevelop-devel mailing list