extragear/sdk/kdevplatform/shell

[Milian Wolff]

On Saturday 17 April 2010 23:41:25 Aleix Pol wrote:
> But that's not the way to fix it. This can lead to errors if there is 2
> instances modifying a session

Which CLI app / test modifies session?

I know it could theoretically be a problem, but right now that's simply not 
the case. All the NoUi apps we have don't use sessions.

> On Sat, Apr 17, 2010 at 7:16 PM, Milian Wolff <mail at milianw.de> wrote:
> > On Saturday 17 April 2010 16:03:52 Aleix Pol wrote:
> > > Why not?
> > 
> > Because that would mean that you can only run one CLI app at the same
> > time. Or
> > only one Unit-Test that uses NoUi Core.
> > 
> > > On Sat, Apr 17, 2010 at 2:31 PM, Milian Wolff <mail at milianw.de> wrote:
> > > > SVN commit 1115775 by mwolff:
> > > > 
> > > > don't lock session in NoUi mode
> > > > 
> > > >  M  +1 -1      core.cpp
> > > > 
> > > > --- trunk/extragear/sdk/kdevplatform/shell/core.cpp #1115774:1115775
> > > > @@ -163,7 +163,7 @@
> > > > 
> > > >     kDebug() << "initializing ui controller";
> > > >     sessionController->initialize();
> > > > 
> > > > -    if(!sessionController->lockSession())
> > > > +    if(!(mode & Core::NoUi) && !sessionController->lockSession())
> > > > 
> > > >     {
> > > >     
> > > >         KMessageBox::error(0, i18n("This session is already active in
> > > > 
> > > > another running instance"));
> > > > 
> > > >         return false;
> > 
> > --
> > Milian Wolff
> > mail at milianw.de
> > http://milianw.de

-- 
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20100418/bdff1e27/attachment.sig>