VCS actions in context menus

[Nicolas Alvarez]

Andreas Pakulat wrote:
> On 02.04.10 16:14:22, Nicolas Alvarez wrote:
>> KDevelop::ContextMenuExtension::VcsGroup is used by several views to get
>> all the VCS-related actions. Several views move all actions from that
>> group into a "Version control" submenu in their context menus.
>> 
>> However, every single VCS plugin I have seen uses ExtensionGroup to add
>> its actions, so there are never any actions in the VcsGroup.
>> 
>> I attach a patch that puts the actions in the right menu (for VCS plugins
>> in kdevplatform; I didn't look at playground plugins yet).
>> 
>> It's definitely the right thing to do
> 
> Sorry, but its not.

Well, it's certainly better than having a group that no VCS uses and every 
view expects, right? ;)

> We've decided to have separate submenus for each VCS
> system as many have special actions anyway. Additionally users often
> expect their vcs actions in a menu named after the vcs they've chosen.
> So we probably should drop the VcsGroup completely.

Why remove the group? Why not keep the VCS actions in VcsGroup, and change 
the views to append them to the menu normally, without adding the submenu?
I think it's better to keep them separated. Someone might want to show VCS 
actions only, and not actions from other extensions...

-- 
Nicolas

(I read mailing lists through Gmane. Please don't Cc me on replies; it makes 
me get one message on my newsreader and another on email.)