Borked diffs created by vcsdiffjob

[Andreas Pakulat]

On 05.09.09 04:18:19, David Nolden wrote:
> At least for subversion, the diffs returned by the svn library seem to be 
> broken. The headers are at the end of the diff, rather than at the correct 
> positions within the diff.
> 
> While making patch-review work with those patches, I had to write a 'repair' 
> function that moves those headers to the correct places, see repairDiff() in 
> vcspluginhelper.cpp. But that is not a good solution. So any Idea why the 
> diffs are borked like that?

Works fine for me, both the diff set in SvnDiffJob::setDiff and the one
fetched in VcsPluginHelper::VCSDiffPatchSource are fine for a small
test (diffing a dir that contains 2 changed files against base). Using
libsvn 1.5.6 from debian here. (I'd paste the output but unfortunately
we didn't yet implement copy/paste for our outputview).

Andreas

-- 
Avoid reality at all costs.