Borked diffs created by vcsdiffjob

David Nolden david.nolden.kdevelop at art-master.de
Sat Sep 5 02:18:19 UTC 2009


At least for subversion, the diffs returned by the svn library seem to be 
broken. The headers are at the end of the diff, rather than at the correct 
positions within the diff.

While making patch-review work with those patches, I had to write a 'repair' 
function that moves those headers to the correct places, see repairDiff() in 
vcspluginhelper.cpp. But that is not a good solution. So any Idea why the 
diffs are borked like that?

How it should be:
"
Index: filename.cpp
==========================
--- filename.cpp (blabla)
+++ filename.cpp (blabla)
blabla
Index: filename2.cpp
==========================
--- filename2.cpp (blabla)
+++ filename2.cpp (blabla)
blabla
"

How it is:
"
--- filename.cpp (blabla)
+++ filename.cpp (blabla)
blabla
--- filename2.cpp (blabla)
+++ filename2.cpp (blabla)
blabla
Index: filename.cpp
==========================
Index: filename2.cpp
==========================
"

Greetings, David





More information about the KDevelop-devel mailing list