Patch to make cmakeManager return clean path

Andreas Pakulat apaku at gmx.de
Sun Nov 15 16:04:37 UTC 2009


On 15.11.09 15:33:17, Benjamin Schindler wrote:
> Hi
> 
> Quite often one gets include path from cmake such as:
> /some/build/dir//someincludeDir
> 
> Even though such a path is valid, some comparisons fails (such as the
> one in includepathcomputer.cpp:208:
> 
>     m_hasPath.contains(r)
> 
> The attached patch fixes this problem. However, I'm not sure whether
> this is the correct solution. The m_hasPath.contains(r) should succeed imho

Exactly, a plain-string check most certainly is the worst way of
testing. I can also think about symlinks and the like easily breaking
this.

Andreas

-- 
You look like a million dollars.  All green and wrinkled.




More information about the KDevelop-devel mailing list