Review request: control flow graph plugin
Milian Wolff
mail at milianw.de
Sun Nov 8 17:57:29 UTC 2009
On Sunday 08 November 2009 18:48:10 Esben Mose Hansen wrote:
> On Sunday 08 November 2009 18:38:35 Milian Wolff wrote:
> > Imo it would be fine if you commit the stuff. But not the tab-one. Adhere
> > to the code-style of the initial author or let him decide to change to
> > spaces.
>
> On Saturday 17 October 2009 20:02:06 Andreas Pakulat wrote:
> > Sooooo first round (no in-depth stuff, but I've looked across the files
> > a bit):
> >
> > - indentation is mixing space and tabs, we usually use space-only, would
> > be nice if you could change that either way so its consistent
>
> You two duke it out ;) If a tab->space fix is going on, I want it at on
> before anything else is pushed. I am withholding any patches until this
> issue is resolved. Merging across the tab-barrier is no fun.
Ah, sorry - I thought it was all tabs and you wanted to move it to spaces. If
it's mixed go ahead and make everything use spaces.
--
Milian Wolff
mail at milianw.de
http://milianw.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20091108/4a5d5c52/attachment.sig>
More information about the KDevelop-devel
mailing list