Deadlock

[Niko Sams]

On Sun, May 17, 2009 at 9:35 PM, David Nolden
<david.nolden.kdevelop at art-master.de> wrote:
> Am Sonntag 17 Mai 2009 19:13:16 schrieb Niko Sams:
>> Hi,
>>
>> I get a deadlock when using the slot implementation helper code
>> completion. Reproducible.
> Should be fixed now (In kdelibs).
thanks.

> Btw. the patch concerns to
> "CodeCompletionControllerInterface::updateCompletionRange" function: Before
> changing the given range, you should not forget locking the smart-lock.
>
> The commit that caused this deadlock was ment to lift that requirement(Which
> can lead to a crash when not fulfilled), but now it needs to be done again. No
> clue if you do it in php support. :)
We just return a custom Range with completionRange(), but we don't
change it dynamically.
So should be no problem.

Niko