Review Request: Simplified IBasicVersionControl::diff

[Fabian Wiesel]

> On 2009-03-23 11:30:14, Andreas Pakulat wrote:
> > /trunk/KDE/kdevplatform/vcs/interfaces/ibasicversioncontrol.h, line 163
> > <http://reviewboard.kde.org/r/395/diff/2/?file=3635#file3635line163>
> >
> >     These namespace changes seem to be unrelated and I don't see the need for them.
> 
>  wrote:
>     You mixed up the old and the new version. It removes the unneeded scope prefix.
>
> 
>  wrote:
>     Hmm, in that case please check the history when these where added and why, I have the suspicion that this is needed for the MS compiler on windows.

Will do that, but it is unlikely, as it is the only  KDevelop:: namespace-prefix for anything. And there are other functions with IBasicVersionControl::Recursive.


- Fabian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/395/#review572
-----------------------------------------------------------


On 2009-03-23 12:06:08, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/395/
> -----------------------------------------------------------
> 
> (Updated 2009-03-23 12:06:08)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> The current IBasicVersionControl::diff interface seems to be too powerful for most VCSs. Replaced it with a simpler one, only allowing diffs between different versions of the same file.
> Moved the old one to Subversion-Plugin, as it is the only one implementing it.
> 
> Did the same with merge() as it requires the same capabilities of the VCS as diff().
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.h 943377 
>   /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.cpp 943377 
>   /trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.h 943377 
>   /trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.cpp 943377 
>   /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.h 943377 
>   /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.cpp 943377 
>   /trunk/KDE/kdevplatform/plugins/vcscommon/kdevvcscommonplugin.cpp 943377 
>   /trunk/KDE/kdevplatform/shell/kross/krossdistributedversioncontrol.h 943377 
>   /trunk/KDE/kdevplatform/shell/kross/krossdistributedversioncontrol.cpp 943377 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.h 943377 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.cpp 943377 
>   /trunk/KDE/kdevplatform/vcs/interfaces/ibasicversioncontrol.h 943377 
>   /trunk/KDE/kdevplatform/vcs/widgets/vcseventwidget.cpp 943377 
> 
> Diff: http://reviewboard.kde.org/r/395/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabian
> 
>