Review Request: Simplified IBasicVersionControl::diff

Fabian Wiesel fabian.wiesel at googlemail.com
Mon Mar 23 19:06:08 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/395/
-----------------------------------------------------------

(Updated 2009-03-23 12:06:08.691334)


Review request for KDevelop.


Changes
-------

Patch against revision 943377


Summary
-------

The current IBasicVersionControl::diff interface seems to be too powerful for most VCSs. Replaced it with a simpler one, only allowing diffs between different versions of the same file.
Moved the old one to Subversion-Plugin, as it is the only one implementing it.

Did the same with merge() as it requires the same capabilities of the VCS as diff().


Diffs (updated)
-----

  /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.h 943377 
  /trunk/KDE/kdevplatform/plugins/cvs/cvsplugin.cpp 943377 
  /trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.h 943377 
  /trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.cpp 943377 
  /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.h 943377 
  /trunk/KDE/kdevplatform/plugins/subversion/kdevsvnplugin.cpp 943377 
  /trunk/KDE/kdevplatform/plugins/vcscommon/kdevvcscommonplugin.cpp 943377 
  /trunk/KDE/kdevplatform/shell/kross/krossdistributedversioncontrol.h 943377 
  /trunk/KDE/kdevplatform/shell/kross/krossdistributedversioncontrol.cpp 943377 
  /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.h 943377 
  /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.cpp 943377 
  /trunk/KDE/kdevplatform/vcs/interfaces/ibasicversioncontrol.h 943377 
  /trunk/KDE/kdevplatform/vcs/widgets/vcseventwidget.cpp 943377 

Diff: http://reviewboard.kde.org/r/395/diff


Testing
-------


Thanks,

Fabian





More information about the KDevelop-devel mailing list