Review Request: Black-box test for (D)VCS-plugins

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/384/#review567
-----------------------------------------------------------



trunk/KDE/kdevelop/vcs/tests/CMakeLists.txt
<http://reviewboard.kde.org/r/384/#comment340>

    Hmm, I don't like linking against shell as its supposed to be an implementation detail of the platform.



trunk/KDE/kdevelop/vcs/tests/vcsBlackBoxTest.cpp
<http://reviewboard.kde.org/r/384/#comment341>

    You mean the svn plugin? If so please create a bugreport at bugs.kde.org with the relevant reproduction steps.



trunk/KDE/kdevelop/vcs/tests/vcsBlackBoxTest.cpp
<http://reviewboard.kde.org/r/384/#comment342>

    If this call is why it links against Core then I suggest to use TestCore from the testshell library.


Other than that the patch looks fine, thanks for writing this.

- Andreas


On 2009-03-22 03:00:43, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/384/
> -----------------------------------------------------------
> 
> (Updated 2009-03-22 03:00:43)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> Tests the various plug-ins on consistency. Currently works with Subversion and Mercurial. CVS needs to be changed to allow local repositories.
> Currently checks:
> All: isVersionControlled(), status(), add(), revert(), commit() 
> DVCS: init()
> 
> The test also codifies a proposal of the expected behaviour of the interfaces, which would be the common denominator of Subversion and Mercurial.
> Because of that, I thought, I'd rather let this be reviewed, before spending more time on implementing more test-cases, which codify an unwanted behaviour.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdevelop/vcs/CMakeLists.txt 942616 
>   trunk/KDE/kdevelop/vcs/tests/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdevelop/vcs/tests/vcsBlackBoxTest.h PRE-CREATION 
>   trunk/KDE/kdevelop/vcs/tests/vcsBlackBoxTest.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/384/diff
> 
> 
> Testing
> -------
> 
> Excluding CVS and Git:
> 
> 1/  1 Testing vcsBlackBoxTest                  Passed
> 
> 100% tests passed, 0 tests failed out of 1
> 
> 
> Thanks,
> 
> Fabian
> 
>