Review Request: KDevPlatform Mercurial plugin v2
Andreas Pakulat
apaku at gmx.de
Sun Mar 15 22:17:34 UTC 2009
On 15.03.09 20:17:54, Fabian Wiesel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/300/
> -----------------------------------------------------------
>
> (Updated 2009-03-15 13:17:54.618385)
>
>
> Review request for KDevelop.
Comitted this meanwhile, had to fix two things:
- The NoDefaultPlugins crept into the git-test
- a broken #include <qt4/Qt/qobject.h> in the mercurial plugin
One thing I wondered about: You removed the add_dvcs method from IDVCS
and I recall that I had longer discussion with Evgeniy that he needs a
"add" that works differently from the one in IBasicVC. So does
git/mercurial's add method now do exactly whats described for IBasicVC
or does it also do what add_dvcs did?
Andreas
--
An avocado-tone refrigerator would look good on your resume.
More information about the KDevelop-devel
mailing list