Review Request: KDevPlatform Mercurial plugin v2

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/300/#review489
-----------------------------------------------------------

Ship it!


Looks fine, I'll commit this now.

- Andreas


On 2009-03-15 13:17:54, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/300/
> -----------------------------------------------------------
> 
> (Updated 2009-03-15 13:17:54)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> This is the second version of my attempt at a Mercurial plugin
> 
> I adopted in DVCSjob::output() the logic from ProcessLineMaker for converting the raw output to QString. Note: Logic will fail in 16-bit charsets (or larger) environments (Windows Unicode).
> 
> IBasicVersionControl is implemented insofar, that all functions called by the context-menu are working (at least for me). Especially the diff-function may fail, if called a different way than the context-menu does.
> 
> "Head" and "Base" map to the latest locally commit revision.
> 
> Functions not directly callable by the context menu are implemented, but untested.
> 
> The following functions are not implemented:
> - update() 
> - merge()
> 
> IDistributedVersionControl has been implemented except for:
> - add_dvcs() as it would the same as IBasicVersionControl::add()
> 
> IDVCSexecutor::branch() is only as so far implemented, that one can create a branch from the currently checked out branch/version.
> Deleting a branch is not possible with the Mercurial version I have.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevplatform/kross/krossdistributedversioncontrol.h 939793 
>   /trunk/KDE/kdevplatform/kross/krossdistributedversioncontrol.cpp 939793 
>   /trunk/KDE/kdevplatform/plugins/CMakeLists.txt 939793 
>   /trunk/KDE/kdevplatform/plugins/git/CMakeLists.txt 939793 
>   /trunk/KDE/kdevplatform/plugins/git/gitexecutor.h 939793 
>   /trunk/KDE/kdevplatform/plugins/git/gitexecutor.cpp 939793 
>   /trunk/KDE/kdevplatform/plugins/git/gitplugin.h 939793 
>   /trunk/KDE/kdevplatform/plugins/git/gitplugin.cpp 939793 
>   /trunk/KDE/kdevplatform/plugins/git/tests/CMakeLists.txt 939793 
>   /trunk/KDE/kdevplatform/plugins/git/tests/initTest.h 939793 
>   /trunk/KDE/kdevplatform/plugins/git/tests/initTest.cpp 939793 
>   /trunk/KDE/kdevplatform/plugins/mercurial/CMakeLists.txt PRE-CREATION 
>   /trunk/KDE/kdevplatform/plugins/mercurial/Messages.sh PRE-CREATION 
>   /trunk/KDE/kdevplatform/plugins/mercurial/kdevmercurial.desktop PRE-CREATION 
>   /trunk/KDE/kdevplatform/plugins/mercurial/kdevmercurial.rc PRE-CREATION 
>   /trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.h PRE-CREATION 
>   /trunk/KDE/kdevplatform/plugins/mercurial/mercurialplugin.cpp PRE-CREATION 
>   /trunk/KDE/kdevplatform/plugins/mercurial/tests/CMakeLists.txt PRE-CREATION 
>   /trunk/KDE/kdevplatform/plugins/mercurial/tests/initTest.h PRE-CREATION 
>   /trunk/KDE/kdevplatform/plugins/mercurial/tests/initTest.cpp PRE-CREATION 
>   /trunk/KDE/kdevplatform/vcs/CMakeLists.txt 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsevent.h PRE-CREATION 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsjob.h 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsjob.cpp 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.h 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/dvcsplugin.cpp 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/idvcsexecutor.h 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/idvcsexecutor.cpp 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/test2/dvcsjobTest.h 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/test2/dvcsjobTest.cpp 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/tests/dvcsjobTest.h 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/tests/dvcsjobTest.cpp 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/branchmanager.h 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/branchmanager.cpp 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/dvcsgenericoutputview.h 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/dvcsgenericoutputview.cpp 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/importdialog.cpp 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/logview.h 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/logview.cpp 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/revhistory/commitView.cpp 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/revhistory/commitlogmodel.h 939793 
>   /trunk/KDE/kdevplatform/vcs/dvcs/ui/revhistory/commitlogmodel.cpp 939793 
>   /trunk/KDE/kdevplatform/vcs/interfaces/idistributedversioncontrol.h 939793 
> 
> Diff: http://reviewboard.kde.org/r/300/diff
> 
> 
> Testing
> -------
> 
>   1/  3 Testing kdevcvs-test                     Passed
>   2/  3 Testing kdevgit-test                     Passed
>   3/  3 Testing kdevmercurial-test               Passed
> 
> 
> Thanks,
> 
> Fabian
> 
>