Review Request: Fixes for Core::initialize(NoGui), added LoadNoPlugins flag for testing plugins

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/331/#review488
-----------------------------------------------------------

Ship it!


Looks fine, except the NULL instead of 0. I'll commit that after reviewing the dvcs patch.

- Andreas


On 2009-03-15 12:47:21, Fabian Wiesel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/331/
> -----------------------------------------------------------
> 
> (Updated 2009-03-15 12:47:21)
> 
> 
> Review request for KDevelop.
> 
> 
> Summary
> -------
> 
> The UIController may not be created, since there is the Core::Setup::NoGUI-flag for testing purposes.
> The documentation controller didn't expect this and crashes. This should be fixed with the patch attached.
> 
> Also, when testing a plugin, other plugins may rely on the existance of UIController, too.
> To avoid complications, I introduced the LoadNoPlugins flag, which disables
> the automated loading of plugins by not calling PluginController::initialize().
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdevplatform/shell/documentcontroller.cpp 939793 
>   /trunk/KDE/kdevplatform/shell/uicontroller.cpp 939793 
> 
> Diff: http://reviewboard.kde.org/r/331/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fabian
> 
>