Review Request: Fixes for Core::initialize(NoGui), added LoadNoPlugins flag for testing plugins

Fabian Wiesel fabian.wiesel at fu-berlin.de
Sun Mar 15 19:47:21 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/331/
-----------------------------------------------------------

(Updated 2009-03-15 12:47:21.465779)


Review request for KDevelop.


Changes
-------

Don't add the LoadNoPlugins flag and still create the UIController.
- In UIController: Check for the existance of the defaultMainWindow(), only then add actions to it
- In DocumentController: Without a gui fileOpenRecent will not be initialised, initialise to NULL and check the access in cleanup().


Summary
-------

The UIController may not be created, since there is the Core::Setup::NoGUI-flag for testing purposes.
The documentation controller didn't expect this and crashes. This should be fixed with the patch attached.

Also, when testing a plugin, other plugins may rely on the existance of UIController, too.
To avoid complications, I introduced the LoadNoPlugins flag, which disables
the automated loading of plugins by not calling PluginController::initialize().


Diffs (updated)
-----

  /trunk/KDE/kdevplatform/shell/documentcontroller.cpp 939793 
  /trunk/KDE/kdevplatform/shell/uicontroller.cpp 939793 

Diff: http://reviewboard.kde.org/r/331/diff


Testing
-------


Thanks,

Fabian





More information about the KDevelop-devel mailing list